Remove deprecated opensearch.ToPointer helper - #881
Draft
Arin016 wants to merge 1 commit into
Draft
Conversation
Arin016
requested review from
Jakob3xD,
VachaShah,
VijayanB and
sean-
as code owners
June 13, 2026 06:17
Arin016
force-pushed
the
remove-topointer
branch
from
June 13, 2026 06:19
a0ae91c to
ae78641
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #881 +/- ##
==========================================
- Coverage 47.39% 47.36% -0.03%
==========================================
Files 1000 1000
Lines 70021 70017 -4
==========================================
- Hits 33189 33167 -22
- Misses 33637 33650 +13
- Partials 3195 3200 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Remove the exported ToPointer generic function and its test. No non-test call sites exist in the tree; internal code uses the unexported per-package ptr helper. Closes opensearch-project#871 Signed-off-by: Arin Mallanna Tumbagi <arin16tumbagi@gmail.com> Signed-off-by: Arin Tumbagi <arin16tumbagi@gmail.com>
Arin016
force-pushed
the
remove-topointer
branch
from
June 13, 2026 15:59
ae78641 to
46e6760
Compare
sean-
reviewed
Jun 15, 2026
sean-
left a comment
sean-
left a comment
Collaborator
There was a problem hiding this comment.
This will be reviewed in August, sometime after Go 1.27 is released and this project subsequently bumps its go.mod to 1.26.
I don't know that the UPDATING entry is required.
sean-
marked this pull request as draft
July 17, 2026 15:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #871
Remove the deprecated
opensearch.ToPointergeneric function and its test. No non-test call sites exist in the tree — internal code uses the unexported per-packageptrhelper.Changes
ToPointerfromopensearch.goTestToPointerfromopensearch_internal_test.goIssues Resolved
Closes #871
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.