Expose merge bug as test was swallowing it - #142
Merged
Conversation
tjake
requested review from
jimdickinson,
sam-herman and
sandoichi
as code owners
August 28, 2025 17:56
sam-herman
approved these changes
Aug 28, 2025
| } | ||
| } finally { | ||
| latch.countDown(); | ||
| log.warn("Ran " + i + " queries"); |
Collaborator
There was a problem hiding this comment.
nit: log.warn("Ran {} queries", i)
log message Signed-off-by: sam-herman <97131656+sam-herman@users.noreply.github.com>
opensearch-trigger-bot Bot
pushed a commit
that referenced
this pull request
Aug 28, 2025
* Expose merge bug as test was swallowing it * Update KNNJVectorTests.java log message Signed-off-by: sam-herman <97131656+sam-herman@users.noreply.github.com> --------- Signed-off-by: sam-herman <97131656+sam-herman@users.noreply.github.com> Co-authored-by: sam-herman <97131656+sam-herman@users.noreply.github.com> (cherry picked from commit 5501720)
sam-herman
added a commit
that referenced
this pull request
Aug 28, 2025
* Expose merge bug as test was swallowing it * Update KNNJVectorTests.java log message --------- (cherry picked from commit 5501720) Signed-off-by: sam-herman <97131656+sam-herman@users.noreply.github.com> Co-authored-by: Jake Luciani <jake@datastax.com> Co-authored-by: sam-herman <97131656+sam-herman@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves resource management and enhances the robustness and logging of concurrent kNN search tests in the
JVectorReaderandKNNJVectorTestsclasses.It was silently failing!
Test Robustness and Logging Improvements:
Throwableinstead ofException, usingcompareAndSetfor atomic failure flag updates, and logging encountered exceptions.Code Clarity:
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.