Fix visited docs tracking that led to assertions on AbstractKnnVectorQuery side

[reta]

Description

Fi visited docs tracking that led to assertions on AbstractKnnVectorQuery side

Related Issues

Fixes (and reverts some #201 changes):

» ERROR][o.o.b.OpenSearchUncaughtExceptionHandler] [knnBwcCluster-rolling-1] fatal error in thread [opensearch[knnBwcCluster-rolling-1][search][T#1]], exiting
»  java.lang.AssertionError
»  	at org.apache.lucene.search.AbstractKnnVectorQuery$ReentrantKnnCollectorManager.newCollector(AbstractKnnVectorQuery.java:379)
»  	at org.apache.lucene.search.TimeLimitingKnnCollectorManager.newCollector(TimeLimitingKnnCollectorManager.java:44)
»  	at org.opensearch.knn.index.codec.jvector.JVectorKnnFloatVectorQuery.approximateSearch(JVectorKnnFloatVectorQuery.java:68)
»  	at org.apache.lucene.search.AbstractKnnVectorQuery.getLeafResults(AbstractKnnVectorQuery.java:194)
»  	at org.apache.lucene.search.AbstractKnnVectorQuery.searchLeaf(AbstractKnnVectorQuery.java:175)
»  	at org.apache.lucene.search.AbstractKnnVectorQuery.lambda$rewrite$1(AbstractKnnVectorQuery.java:138)
»  	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
»  	at org.apache.lucene.search.TaskExecutor$Task.run(TaskExecutor.java:173)
»  	at org.apache.lucene.search.TaskExecutor.invokeAll(TaskExecutor.java:111)
»  	at org.apache.lucene.search.AbstractKnnVectorQuery.runSearchTasks(AbstractKnnVectorQuery.java:161)
»  	at org.apache.lucene.search.AbstractKnnVectorQuery.rewrite(AbstractKnnVectorQuery.java:147)
»  	at org.apache.lucene.search.KnnFloatVectorQuery.rewrite(KnnFloatVectorQuery.java:48)
»  	at org.apache.lucene.search.IndexSearcher.rewrite(IndexSearcher.java:874)
»  	at org.opensearch.search.internal.ContextIndexSearcher.rewrite(ContextIndexSearcher.java:213)
»  	at org.opensearch.search.DefaultSearchContext.preProcess(DefaultSearchContext.java:449)
»  	at org.opensearch.search.query.QueryPhase.preProcess(QueryPhase.java:128)
»  	at org.opensearch.search.SearchService.createContext(SearchService.java:1282)
»  	at org.opensearch.search.SearchService.executeQueryPhase(SearchService.java:836)
»  	at org.opensearch.search.SearchService$2.lambda$onResponse$0(SearchService.java:802)
»  	at org.opensearch.action.ActionRunnable.lambda$supply$0(ActionRunnable.java:74)
»  	at org.opensearch.action.ActionRunnable$2.doRun(ActionRunnable.java:89)
»  	at org.opensearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:52)
»  	at org.opensearch.threadpool.TaskAwareRunnable.doRun(TaskAwareRunnable.java:78)
»  	at org.opensearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:52)
»  	at org.opensearch.common.util.concurrent.TimedRunnable.doRun(TimedRunnable.java:59)
»  	at org.opensearch.common.util.concurrent.ThreadContext$ContextPreservingAbstractRunnable.doRun(ThreadContext.java:975)
»  	at org.opensearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:52)
»  	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
»  	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
»  	at java.base/java.lang.Thread.run(Thread.java:1583)

Check List

• New functionality includes testing.
• New functionality has been documented.
• API changes companion pull request created.
• Commits are signed per the DCO using --signoff.
• Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[opensearch-trigger-bot]

The backport to 3.3.2 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-3.3.2 3.3.2
# Navigate to the new working tree
cd .worktrees/backport-3.3.2
# Create a new branch
git switch --create backport/backport-238-to-3.3.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1c9a709f2e92b96491f56c7fe39a1802fa19a57c
# Push it to GitHub
git push --set-upstream origin backport/backport-238-to-3.3.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-3.3.2

Then, create a pull request where the base branch is 3.3.2 and the compare/head branch is backport/backport-238-to-3.3.2.