Skip to content

Fix flaky org.opensearch.knn.index.codec.jvector.KNNJVectorTests.testJVectorKnnIndex_mergeEnabled (2nd attempt) - #362

Merged
reta merged 4 commits into
opensearch-project:mainfrom
reta:issue-281.2
Apr 6, 2026
Merged

Fix flaky org.opensearch.knn.index.codec.jvector.KNNJVectorTests.testJVectorKnnIndex_mergeEnabled (2nd attempt)#362
reta merged 4 commits into
opensearch-project:mainfrom
reta:issue-281.2

Conversation

@reta

@reta reta commented Apr 6, 2026

Copy link
Copy Markdown
Collaborator

Description

Fix flaky org.opensearch.knn.index.codec.jvector.KNNJVectorTests.testJVectorKnnIndex_mergeEnabled (2nd attempt)

Related Issues

Closes #281

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…JVectorKnnIndex_mergeEnabled (2nd attempt)

Signed-off-by: Andriy Redko <drreta@gmail.com>
Comment thread src/test/java/org/opensearch/knn/index/codec/jvector/KNNJVectorTests.java Outdated
Comment thread src/test/java/org/opensearch/knn/index/engine/CommonTestUtils.java Outdated
reta added 2 commits April 6, 2026 16:06
Signed-off-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Andriy Redko <drreta@gmail.com>
@reta
reta merged commit 4035056 into opensearch-project:main Apr 6, 2026
33 of 41 checks passed
@opensearch-trigger-bot

Copy link
Copy Markdown
Contributor

The backport to 3.5 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-3.5 3.5
# Navigate to the new working tree
cd .worktrees/backport-3.5
# Create a new branch
git switch --create backport/backport-362-to-3.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4035056b9b50041830bcf49b5a22959f25b6820d
# Push it to GitHub
git push --set-upstream origin backport/backport-362-to-3.5
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-3.5

Then, create a pull request where the base branch is 3.5 and the compare/head branch is backport/backport-362-to-3.5.

opensearch-trigger-bot Bot pushed a commit that referenced this pull request Apr 6, 2026
…JVectorKnnIndex_mergeEnabled (2nd attempt) (#362)

* Fix flaky org.opensearch.knn.index.codec.jvector.KNNJVectorTests.testJVectorKnnIndex_mergeEnabled (2nd attempt)

Signed-off-by: Andriy Redko <drreta@gmail.com>

* Reduce number of documents to 10

Signed-off-by: Andriy Redko <drreta@gmail.com>

* Address code review comments

Signed-off-by: Andriy Redko <drreta@gmail.com>

* Address code review comments

Signed-off-by: Andriy Redko <drreta@gmail.com>

---------

Signed-off-by: Andriy Redko <drreta@gmail.com>
(cherry picked from commit 4035056)
reta added a commit that referenced this pull request Apr 6, 2026
…JVectorKnnIndex_mergeEnabled (2nd attempt) (#362) (#363)

* Fix flaky org.opensearch.knn.index.codec.jvector.KNNJVectorTests.testJVectorKnnIndex_mergeEnabled (2nd attempt)



* Reduce number of documents to 10



* Address code review comments



* Address code review comments



---------


(cherry picked from commit 4035056)

Signed-off-by: Andriy Redko <drreta@gmail.com>
Co-authored-by: Andriy Redko <drreta@gmail.com>
reta added a commit to reta/opensearch-jvector that referenced this pull request Apr 7, 2026
…JVectorKnnIndex_mergeEnabled (2nd attempt) (opensearch-project#362) (opensearch-project#363)

* Fix flaky org.opensearch.knn.index.codec.jvector.KNNJVectorTests.testJVectorKnnIndex_mergeEnabled (2nd attempt)

* Reduce number of documents to 10

* Address code review comments

* Address code review comments

---------

(cherry picked from commit 4035056)

Signed-off-by: Andriy Redko <drreta@gmail.com>
Co-authored-by: Andriy Redko <drreta@gmail.com>
(cherry picked from commit 4ab1063)
reta added a commit that referenced this pull request Apr 7, 2026
…JVectorKnnIndex_mergeEnabled (2nd attempt) (#362) (#363) (#365)

* Fix flaky org.opensearch.knn.index.codec.jvector.KNNJVectorTests.testJVectorKnnIndex_mergeEnabled (2nd attempt)

* Reduce number of documents to 10

* Address code review comments

* Address code review comments

---------

(cherry picked from commit 4035056)



(cherry picked from commit 4ab1063)

Signed-off-by: Andriy Redko <drreta@gmail.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Fix flaky org.opensearch.knn.index.codec.jvector.KNNJVectorTests.testJVectorKnnIndex_mergeEnabled

2 participants