Fix flaky org.opensearch.knn.index.engine.InternalKNNEngineTests.testJVectorSearchStatsIncrement (followup) - #364
Merged
Conversation
reta
requested review from
akash-shankaran,
jimdickinson,
sam-herman and
sandoichi
as code owners
April 6, 2026 21:15
….JVectorSearchStatsIncrement (followup) Signed-off-by: Andriy Redko <drreta@gmail.com>
reta
commented
Apr 6, 2026
| createKnnIndexMappingWithJVectorEngine(dimension, SpaceType.L2, VectorDataType.FLOAT); | ||
|
|
||
| // Disable refresh for the index | ||
| client().admin() |
Collaborator
Author
There was a problem hiding this comment.
@akash-shankaran this is one of the fixes I have tried but didn't include into original pull request, however it looks to be required.
akash-shankaran
approved these changes
Apr 7, 2026
This was referenced Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix flaky org.opensearch.knn.index.engine.InternalKNNEngineTests.testJVectorSearchStatsIncrement (followup, disable refresh).
Related Issues
Followup on #359
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.