Skip to content

[Backport] [3.5] Fix flaky org.opensearch.knn.index.engine.InternalKNNEngineTests.testVectorEngineWithConstructionParameters #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reta merged 1 commit into from
Apr 7, 2026
Merged

[Backport] [3.5] Fix flaky org.opensearch.knn.index.engine.InternalKNNEngineTests.testVectorEngineWithConstructionParameters #373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions src/test/java/org/opensearch/knn/index/engine/InternalKNNEngineTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,22 +561,26 @@ public void testQuantizationWithOverQueryParameter() throws Exception {
final RestClient restClient = getRestClient();
createKnnIndexMappingWithJVectorEngine(dimension, spaceType, VectorDataType.FLOAT);

// Choosing a batch size that will trigger quantization
// Disable refresh for the index
client().admin()
.indices()
.prepareUpdateSettings(INDEX_NAME)
.setSettings(Settings.builder().put(IndexSettings.INDEX_REFRESH_INTERVAL_SETTING.getKey(), -1))
.get();

// Choosing a batch size that should definitely trigger quantization
int batchSize = DEFAULT_MINIMUM_BATCH_SIZE_FOR_QUANTIZATION * 2;

final float[][] vectors = TestUtils.generateRandomVectors(batchSize, dimension);
final int totalDocs = vectors.length;

logger.info("Adding batch of vectors with size {} that is expected to trigger quantization", totalDocs);
CommonTestUtils.bulkAddKnnDocs(restClient, INDEX_NAME, FIELD_NAME, vectors, batchSize, false, 1000);
CommonTestUtils.flushIndex(restClient, INDEX_NAME);

// Force merge to trigger quantization for all segments
logger.info("Force merging just in case quantization didn't happen because of segment fragmentation");
CommonTestUtils.forceMergeKnnIndex(restClient, INDEX_NAME);

// Verify the total document count
int expectedTotalDocs = vectors.length;
logger.info("Adding batch of vectors with size {} that is expected to trigger quantization", totalDocs);
CommonTestUtils.bulkAddKnnDocs(restClient, INDEX_NAME, FIELD_NAME, vectors, batchSize, false, batchSize);
flushAndRefresh(INDEX_NAME);

// Verify the total document count (we expect 1 segment)
assertEquals(expectedTotalDocs, CommonTestUtils.getDocCount(restClient, INDEX_NAME));

// Perform search and verify recall
Expand Down
Loading