Skip to content

[DRAFT] [DO NOT MERGE] Faiss exploration - #718

Draft
ergunkezer1 wants to merge 2 commits into
opensearch-project:mainfrom
ergunkezer1:issue-496-faiss
Draft

[DRAFT] [DO NOT MERGE] Faiss exploration#718
ergunkezer1 wants to merge 2 commits into
opensearch-project:mainfrom
ergunkezer1:issue-496-faiss

Conversation

@ergunkezer1

Copy link
Copy Markdown
Contributor

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ergunkezer1 ergunkezer1 changed the title [DRAFT] Faiss exploaration [DRAFT] [DO NOT MERGE] Faiss exploaration Sep 2, 2026
@ergunkezer1
ergunkezer1 marked this pull request as draft September 2, 2026 15:21
@reta reta changed the title [DRAFT] [DO NOT MERGE] Faiss exploaration [DRAFT] [DO NOT MERGE] Faiss exploration Sep 2, 2026
Comment thread src/main/java/org/apache/lucene/sandbox/codecs/faiss/FaissKnnVectorsFormat.java Outdated
Comment thread gradle.properties
systemProp.bwc.version=3.2.0
jvector_version=4.0.0-rc.9
java_release_version=21
java_release_version=25

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change required? Our baseline us 21 for now

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FAISS implementation is using Panama FFM and a couple feature weren't supported with v21

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, the question is - would it compile but have runtime hit, or it won't compile at all on JDK-21?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compile time error:

A problem occurred configuring root project 'lucene-root'.

Could not resolve all dependencies for configuration 'classpath'.
Could not resolve project ':build-infra'.
Required by:
buildscript of root project 'lucene-root'
> Dependency requires at least JVM runtime version 25. This build uses a Java 21 JVM.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, we need Lucene 11 which is JDK-25 baseline, this is a bummer for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants