Fix: Respect storageClassName="" for static provisioning #1097
+62
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix resolves an issue where setting `storageClassName: ""` in the PVC configuration was incorrectly ignored, causing the operator to use the default StorageClass instead of disabling dynamic provisioning as per Kubernetes specifications. Fixes opensearch-project#1096 Updated the logic to always return a pointer to the storageClassName when persistence is configured, allowing proper differentiation between: - No persistence specified → nil (uses default StorageClass) - storageClass: "" → &"" (disables dynamic provisioning) - storageClass: "my-class" → &"my-class" (uses specific class) Related to commit 0bea273 which originally introduced the problematic check. Signed-off-by: Itamar Syn-Hershko <[email protected]>
synhershko
requested review from
idanl21,
jochenkressin,
pchmielnik,
prudhvigodithi,
salyh and
swoehrl-mw
as code owners
There was a problem hiding this comment.
Could you explain why we need a separate test file for SC handling again? I think new tests you added in cluster_test.go is enough.
Signed-off-by: josedev-union <[email protected]>
josedev-union
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix resolves an issue where setting
storageClassName: ""in the PVC configuration was incorrectly ignored, causing the operator to use the default StorageClass instead of disabling dynamic provisioning as per Kubernetes specifications.Fixes
#1096
Updated the logic to always return a pointer to the storageClassName when persistence is configured, allowing proper differentiation between:
Related to commit 0bea273 which originally introduced the problematic check.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.