Skip to content

Conversation

patelsmit32123
Copy link
Contributor

@patelsmit32123 patelsmit32123 commented Sep 16, 2025

Description

Currently, bootstrap pod spec doesn't support adding annotations. This change adds the support.

Annotations were supported for node pools but was missing in helm charts, so added that as well.

Issues Resolved

#1098

Check List

  • Commits are signed per the DCO using --signoff
  • Unittest added for the new/changed functionality and all unit tests are successful
  • Customer-visible features documented
  • No linter warnings (make lint)

If CRDs are changed:

  • CRD YAMLs updated (make manifests) and also copied into the helm chart
  • Changes to CRDs documented

Please refer to the PR guidelines before submitting this pull request.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@patelsmit32123 patelsmit32123 changed the title Added support for bootstrap pod annotations Add support for bootstrap pod annotations Sep 16, 2025
@patelsmit32123 patelsmit32123 force-pushed the bootstrap-pod-annotations branch 2 times, most recently from 46250ef to 7a5c6dc Compare September 16, 2025 15:48
@patelsmit32123
Copy link
Contributor Author

@prudhvigodithi please review when you can

Signed-off-by: Smit Patel <[email protected]>
Signed-off-by: patelsmit32123 <[email protected]>
@patelsmit32123 patelsmit32123 force-pushed the bootstrap-pod-annotations branch from 7a5c6dc to fcd3bcf Compare September 19, 2025 10:10
@prudhvigodithi
Copy link
Member

Thanks @patelsmit32123, i'm ok with this change, but just curious the lifetime of bootstrap pod is short and start a new cluster without this bootstrap pod, is there a strong reason to add the annotations? I would love to see a proposal/RFC to completely remove the bootstrap logic and start the cluster directly with user defined node pools while handling the security settings as well.
CC @rootxrishabh

@patelsmit32123
Copy link
Contributor Author

patelsmit32123 commented Sep 30, 2025

Thanks @patelsmit32123, i'm ok with this change, but just curious the lifetime of bootstrap pod is short and start a new cluster without this bootstrap pod, is there a strong reason to add the annotations?

At Uber, we don't have per-pod-ip (only host ip) and use dynamic ports for colocation of pods, so the k8s scheduler assigns ports via specific annotations and we need to assign one for bootstrap pod as well.

@synhershko
Copy link

LGTM

@prudhvigodithi prudhvigodithi merged commit 36c2b39 into opensearch-project:main Oct 4, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Engineering Effectiveness Board Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants