[WIP] Use docker image's default startup command and install plugins via init container #1115
+174
−132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patelsmit32123
requested review from
idanl21,
jochenkressin,
pchmielnik,
prudhvigodithi,
salyh and
swoehrl-mw
as code owners
…it container Signed-off-by: patelsmit32123 <[email protected]>
patelsmit32123
force-pushed
the
default-startup-command
branch
from
e9e89fb to
d2c3266
Compare
patelsmit32123
changed the title
| Expect(pluginInstaller).ToNot(BeNil()) | ||
| Expect(pluginInstaller.Command).To(ContainElement("/bin/bash")) | ||
| Expect(pluginInstaller.Command).To(ContainElement("-c")) | ||
| Expect(len(pluginInstaller.VolumeMounts)).To(Equal(0)) // No volume mounts needed |
There was a problem hiding this comment.
Need to make sure what paths we have to share with the main container to reflect the plugin installation.
Then use volume for that path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Resolved
#1111
Check List
make lint)If CRDs are changed:
make manifests) and also copied into the helm chartPlease refer to the PR guidelines before submitting this pull request.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.