Fix: SnapshotPolicy deletion schedule incorrectly uses creation schedule #1122
+77
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix deletion schedule to use r.instance.Spec.Deletion.Schedule instead of r.instance.Spec.Creation.Schedule - Add nil check for r.instance.Spec.Deletion.Schedule to prevent panic - Add unit tests to verify deletion schedule is used correctly - Add unit test for nil deletion schedule case Signed-off-by: Dmitry Teikovtcev <[email protected]>
daimon243
requested review from
idanl21,
jochenkressin,
pchmielnik,
prudhvigodithi,
salyh and
swoehrl-mw
as code owners
prudhvigodithi
approved these changes
Oct 11, 2025
github-project-automation
bot
moved this to 👀 In Review
in Engineering Effectiveness Board
|
Thanks for your contribution @daimon243, this is an important bug fix. |
github-project-automation
bot
moved this from 👀 In Review
to ✅ Done
in Engineering Effectiveness Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix bug in SnapshotPolicy where deletion schedule incorrectly uses creation schedule values instead of deletion schedule values.
Changes:
r.instance.Spec.Deletion.Scheduleinstead ofr.instance.Spec.Creation.Scheduler.instance.Spec.Deletion.Scheduleto prevent panicIssues Resolved
Closes #1121 - Bug: SnapshotPolicy deletion schedule incorrectly uses creation schedule
Check List
make lint)If CRDs are changed:
make manifests) and also copied into the helm chartPlease refer to the PR guidelines before submitting this pull request.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.