Make --source-version required
#1058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternied
requested review from
AndreKurait,
chelma,
gregschohn,
lewijacn,
mikaylathompson and
sumobrian
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1058 +/- ##
============================================
- Coverage 80.19% 80.18% -0.01%
- Complexity 2863 2867 +4
============================================
Files 383 383
Lines 14333 14340 +7
Branches 988 989 +1
============================================
+ Hits 11494 11499 +5
- Misses 2245 2247 +2
Partials 594 594
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
By defaulting to ES 7.10 this caused confusion with the version parameter was not passed into RFS for different snapshot sources. While this does require all customers to follow the same path it will prevent strange errors when the snapshot reader is unable to parse the snapshot. Signed-off-by: Peter Nied <[email protected]>
peternied
force-pushed
the
source-version-required
branch
from
caf53c9 to
74809c8
Compare
Signed-off-by: Peter Nied <[email protected]>
AndreKurait
requested changes
Oct 9, 2024
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
AndreKurait
reviewed
Oct 16, 2024
Signed-off-by: Andre Kurait <[email protected]>
Signed-off-by: Andre Kurait <[email protected]>
AndreKurait
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By defaulting to ES 7.10 this caused confusion with the version parameter was not passed into RFS for different snapshot sources. While this does require all customers to follow the same path it will prevent strange errors when the snapshot reader is unable to parse the snapshot.
Issues Resolved
Check List
New functionality includes testingAll tests pass, including unit test, integration test and doctestBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.