Skip to content

Conversation

peternied
Copy link
Member

@peternied peternied commented Oct 14, 2024

Description

Expand target support to OpenSearch v1.3

Updated the java end to end test cases to read from the same list for
target platforms.

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.64%. Comparing base (85d5846) to head (a7c98aa).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ions/bulkload/transformers/TransformFunctions.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1074      +/-   ##
============================================
+ Coverage     80.18%   80.64%   +0.45%     
- Complexity     2867     2894      +27     
============================================
  Files           383      383              
  Lines         14340    14342       +2     
  Branches        989      989              
============================================
+ Hits          11499    11566      +67     
+ Misses         2247     2183      -64     
+ Partials        594      593       -1     
Flag Coverage Δ
gradle-test 78.75% <75.00%> (+0.54%) ⬆️
python-test 90.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Updated the java end to end test cases to read from the same list for
target platforms.

Signed-off-by: Peter Nied <[email protected]>
Copy link
Collaborator

@gregschohn gregschohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Since there's no documentation change that says that we support OS1.x in this PR, this change by itself makes the codebase better & I'm happy to approve it.

However, I'd like to see one more case added to the ParallelDocumentMigrationsTest (it's already setup to take a list of targets and do parameterized testing, so it's one line). That test will take into account any differences that might occur in work coordination due to running on a different version of the cluster doing the work coordination.

@peternied peternied merged commit d7224ce into opensearch-project:main Oct 17, 2024
13 of 14 checks passed
@peternied peternied deleted the target-OS_1_3 branch October 17, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants