generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 40
Include AWS Solution cloud formation template #1101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
60e1b90
Include AWS Solution cloudformation template
peternied e6c6dd0
Update readmes, add tests, and update CI
peternied 38c39c3
PR Feedback & enable linting during tests
peternied f8ec1d2
Multiple deployments in the same region
peternied 7397ade
Update the readme to include the new options
peternied File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
import 'source-map-support/register'; | ||
import { App, DefaultStackSynthesizer } from 'aws-cdk-lib'; | ||
import { SolutionsInfrastructureStack } from '../lib/solutions-stack'; | ||
|
||
const getProps = () => { | ||
const { CODE_BUCKET, SOLUTION_NAME, CODE_VERSION } = process.env; | ||
if (typeof CODE_BUCKET !== 'string' || CODE_BUCKET.trim() === '') { | ||
console.warn(`Missing environment variable CODE_BUCKET, using a default value`); | ||
} | ||
|
||
if (typeof SOLUTION_NAME !== 'string' || SOLUTION_NAME.trim() === '') { | ||
console.warn(`Missing environment variable SOLUTION_NAME, using a default value`); | ||
} | ||
|
||
if (typeof CODE_VERSION !== 'string' || CODE_VERSION.trim() === '') { | ||
console.warn(`Missing environment variable CODE_VERSION, using a default value`); | ||
} | ||
|
||
const codeBucket = CODE_BUCKET ?? "Unknown"; | ||
const solutionVersion = CODE_VERSION ?? "Unknown"; | ||
const solutionName = SOLUTION_NAME ?? "MigrationAssistant"; | ||
const solutionId = 'SO0290'; | ||
const description = `(${solutionId}) - The AWS CloudFormation template for deployment of the ${solutionName}. Version ${solutionVersion}`; | ||
return { | ||
codeBucket, | ||
solutionVersion, | ||
solutionId, | ||
solutionName, | ||
description | ||
}; | ||
}; | ||
|
||
const app = new App(); | ||
const infraProps = getProps() | ||
new SolutionsInfrastructureStack(app, 'OSMigrations-Bootstrap', { | ||
synthesizer: new DefaultStackSynthesizer(), | ||
...infraProps | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
deployment/migration-assistant-solution/test/solutions-stack.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not opposed to changing this naming pattern, but this definitely requires an update to our Solutions documentation which expect the previous naming pattern so just putting on your radar