Skip to content

[Bug] Cleanup deployment fix for paginated list stacks #1111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2024
Merged

[Bug] Cleanup deployment fix for paginated list stacks #1111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/cleanupDeployment/cleanup_deployment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ def delete_stacks_for_environment(stage_name: str):
next_stack_names = [stack['StackName'] for stack in next_list_stacks_response['StackSummaries']
if stack['StackStatus'] not in CFN_INITIAL_STATUS_SKIP]
stack_names.extend(next_stack_names)
list_stacks_response.get("NextToken", None)
next_token = next_list_stacks_response.get("NextToken", None)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: switch to do {} while pattern to prevent this kind of bug in the future


stage_stack_names = []
for name in stack_names:
Expand All @@ -151,6 +151,7 @@ def delete_stacks_for_environment(stage_name: str):


def main():
logging.info("Starting cleanup deployment process")
parser = argparse.ArgumentParser(description="Cleanup an opensearch-migrations deployment environment.")
parser.add_argument("--stage", type=str, help="The deployment stage environment to delete")
args = parser.parse_args()
Expand Down