Generate two CFN templates for create VPC and import VPC for bootstrap

[lewijacn]

Description

Changes functionality to generate two CFN templates for create VPC and import VPC for bootstrap. As well as introduces VPC Id and Subnet intake from CFN parameters that will later be used when deploying the Migration Assistant CDK

Import VPC v1

Import VPC v2

Create VPC

Issues Resolved

https://opensearch.atlassian.net/browse/MIGRATIONS-2166

Is this a backport? If so, please add backport PR # and/or commits #

Testing

Manual CFN deployment testing
CDK tests

Check List

• New functionality includes testing
  • All tests pass, including unit test, integration test and doctest
• New functionality has been documented
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.55%. Comparing base (dc326f0) to head (d03df5a).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #1113   +/-   ##
=========================================
  Coverage     80.55%   80.55%           
  Complexity     2930     2930           
=========================================
  Files           390      390           
  Lines         14462    14462           
  Branches        998      998           
=========================================
  Hits          11650    11650           
  Misses         2209     2209           
  Partials        603      603           

Flag	Coverage Δ
gradle-test	78.63% <ø> (ø)
python-test	90.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[peternied]

Thanks for working on this, I'll do another pass on the text-descriptions, but these are a huge improvement!

[peternied]

Thanks for those updates, a shame about the conditions being not very useful. Going into more nitpicky UX. Could you also see about reviewing the UX with product? - Happy to any additional changes happen out of band of this change.

[peternied]

Why aren't we including all AZ's/subnets pairs specified by the customer?

Curious, if we don't need them to find the VPC, does this mean that we could accidentally allocate resources under subnets other than the ones specified by the user?

[lewijacn]

My understanding is that since we are not doing lookup and instead essentially crafting parts of an existing VPC from attributes, we will only use attributes that we have specified and no lookup is actually happening. This CFN itself only needs one subnet and one AZ for our EC2 instance