Skip to content

Conversation

AndreKurait
Copy link
Member

@AndreKurait AndreKurait commented Nov 5, 2024

Description

Minor pr followup from #1110.

Added a comment and renamed a class. No functional difference

  • Category: Maintenance
  • Why these changes are required? Code Cleanup
  • What is the old behavior before changes and new behavior after changes? None

Issues Resolved

N/A

Is this a backport? If so, please add backport PR # and/or commits #

Testing

See GHA

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andre Kurait <[email protected]>
@AndreKurait AndreKurait force-pushed the BulkDocSectionComment branch from 47f60c4 to 280592e Compare November 5, 2024 19:37
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.53%. Comparing base (e78d172) to head (280592e).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...rch/migrations/bulkload/common/BulkDocSection.java 85.71% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1117      +/-   ##
============================================
+ Coverage     80.40%   80.53%   +0.12%     
+ Complexity     2944     2873      -71     
============================================
  Files           393      393              
  Lines         14536    14554      +18     
  Branches       1001     1000       -1     
============================================
+ Hits          11688    11721      +33     
+ Misses         2242     2227      -15     
  Partials        606      606              
Flag Coverage Δ
gradle-test 78.62% <85.71%> (+0.15%) ⬆️
python-test 90.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndreKurait AndreKurait closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant