Add disabled annotation to SnapshotState tests #1365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaylathompson
requested review from
AndreKurait,
chelma,
gregschohn,
jugal-chauhan,
lewijacn,
peternied and
sumobrian
as code owners
mikaylathompson
had a problem deploying
to
migrations-cicd
GitHub Actions
Failure
Signed-off-by: Mikayla Thompson <[email protected]>
mikaylathompson
force-pushed
the
disable-snapshot-state-tests
branch
from
7e8cd3b to
1ea29b0
Compare
mikaylathompson
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1365 +/- ##
============================================
- Coverage 79.91% 79.91% -0.01%
+ Complexity 2976 2975 -1
============================================
Files 442 442
Lines 16213 16213
Branches 1086 1086
============================================
- Hits 12957 12956 -1
- Misses 2616 2617 +1
Partials 640 640
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
peternied
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Solutions pipeline is blocked by mysterious failures in the SnapshotState tests. While we debug that, this is an emergency measure to unblock it. We believe this is a low risk test to disable because the logic is covered by other tests.
Issues Resolved
Testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.