Skip to content

Conversation

peternied
Copy link
Member

Description

Every week will make a consolidated PR for our major dependency areas for npm, gradle, and github actions.

Issues Resolved

Testing

Its running on my fork, now the only changes needed to get outstanding PRs merged is fixes due to incoming library changes.

Check List

  • New functionality includes testing
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Every week will make a consolidated PR for our major dependency areas
for npm, gradle, and github actions.

Signed-off-by: Peter Nied <[email protected]>
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.91%. Comparing base (a5d393f) to head (001fa8d).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1366   +/-   ##
=========================================
  Coverage     79.91%   79.91%           
  Complexity     2977     2977           
=========================================
  Files           443      443           
  Lines         16217    16217           
  Branches       1087     1087           
=========================================
  Hits          12960    12960           
  Misses         2617     2617           
  Partials        640      640           
Flag Coverage Δ
unittests 79.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lewijacn
Copy link
Collaborator

Anything we can do so that all CDK dependencies with the same CDK lib version, are consistent? We have had an issue in the past when these versions aren't uniform, https://github.com/peternied/opensearch-migrations/pull/35/files

    "@aws-cdk/aws-servicecatalogappregistry-alpha": "2.179.0-alpha.0",
    "@aws-cdk/aws-msk-alpha": "2.179.0-alpha.0",
    "aws-cdk": "2.179.0",
    "aws-cdk-lib": "2.179.0",

To

   "@aws-cdk/aws-servicecatalogappregistry-alpha": "2.179.0-alpha.0",
    "@aws-cdk/aws-msk-alpha": "2.179.0-alpha.0",
    "aws-cdk": "2.1005.0",
    "aws-cdk-lib": "2.184.1",

@peternied
Copy link
Member Author

Anything we can do so that all CDK dependencies with the same CDK lib version, are consistent?

CI checks are running on the PR, is that good enough? Looking at the generated PR @aws-sdk/client-acm, @aws-sdk/client-kafka, @aws-sdk/client-lambda were all on different versions.

@peternied peternied merged commit f57b820 into opensearch-project:main Mar 20, 2025
60 checks passed
@peternied peternied deleted the dependabot-weekly branch March 20, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants