Provide terminating status for K8s console library #1374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tanner Lewis <[email protected]>
lewijacn
requested review from
AndreKurait,
chelma,
gregschohn,
jugal-chauhan,
mikaylathompson,
peternied and
sumobrian
as code owners
lewijacn
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
Signed-off-by: Tanner Lewis <[email protected]>
lewijacn
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
Signed-off-by: Tanner Lewis <[email protected]>
lewijacn
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
Signed-off-by: Tanner Lewis <[email protected]>
lewijacn
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
Signed-off-by: Tanner Lewis <[email protected]>
lewijacn
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1374 +/- ##
============================================
- Coverage 80.13% 80.11% -0.02%
Complexity 2978 2978
============================================
Files 440 440
Lines 16188 16207 +19
Branches 1078 1078
============================================
+ Hits 12972 12985 +13
- Misses 2582 2588 +6
Partials 634 634
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
peternied
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To allow for more accurate status tracking of K8s pods, this introduces a
TERMINATINGstatus for K8s services so that users and our test cases can better tell when a service has completely scaled down.This change also refactors to use the K8s python client as there doesn't seem to be a good reason to use the
kubectlcommand directlyIssues Resolved
N/A
Testing
Unit testing and local K8s testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.