javascript:S5852 Improve perf on bulk request matcher #1380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Nied <[email protected]>
peternied
requested review from
AndreKurait,
chelma,
gregschohn,
jugal-chauhan,
lewijacn,
mikaylathompson and
sumobrian
as code owners
peternied
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
AndreKurait
reviewed
Mar 24, 2025
...rmers/jsonTypeMappingsSanitizationTransformer/src/main/resources/js/typeMappingsSanitizer.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Peter Nied <[email protected]>
peternied
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
AndreKurait
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
AndreKurait
reviewed
Mar 25, 2025
| const CREATE_INDEX_REGEX = /(?:PUT|POST) \/([^/]*)/; | ||
| const INDEX_BULK_REQUEST_REGEX = /(?:PUT|POST) \/([^/]+)\/_bulk/; | ||
| const INDEX_TYPE_BULK_REQUEST_REGEX = /(?:PUT|POST) \/([^/]+)\/([^/]+)\/_bulk/; | ||
| const BULK_URI_INDEX_PATTERN_REGEX = /^.+\/(?:[^/]+\/)?_bulk/; |
There was a problem hiding this comment.
Would have preferred /^.*?\/_bulk/;, but this appears to work
AndreKurait
approved these changes
Mar 25, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1380 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
javascript:S5852 Improve perf on bulk request matcher
Issues Resolved
Check List
New functionality includes testingPublic documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.