SonarQube Code Smells 2.3 release #1381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dlerFactory is closed Signed-off-by: Andre Kurait <[email protected]>
Signed-off-by: Andre Kurait <[email protected]>
AndreKurait
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
AndreKurait
commented
Mar 24, 2025
| S3AsyncClient s3Client = S3AsyncClient.crtBuilder() | ||
| .credentialsProvider(DefaultCredentialsProvider.create()) | ||
| .region(Region.of(s3Region)) | ||
| .credentialsProvider(DefaultCredentialsProvider.create()) |
There was a problem hiding this comment.
Attempt to fix lingering sonarqube issue on this builder by changing the order here to match sonarqube's documentation
AndreKurait
commented
Mar 24, 2025
| Predicate<String> contentTypeFilter) { | ||
| // ContentType not text if specified and has a value with / and that value does not start with text/ | ||
| return Optional.ofNullable(capturedHttpJsonMessage.headers().insensitiveGet(HttpHeaderNames.CONTENT_TYPE.toString())) | ||
| return Optional.ofNullable(message.headers().insensitiveGet(HttpHeaderNames.CONTENT_TYPE.toString())) |
There was a problem hiding this comment.
This is not a behavior change since we were only passing in capturedHttpJsonMessage to this method, but it should use the parameter message nonetheless
AndreKurait
requested review from
chelma,
gregschohn,
jugal-chauhan,
lewijacn,
mikaylathompson,
peternied and
sumobrian
as code owners
AndreKurait
changed the title
peternied
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SonarQube code smells for 2.3 release
Issues Resolved
Testing
See GHA
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.