-
Notifications
You must be signed in to change notification settings - Fork 40
Large snapshot generator test #1445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
7f2fc6e
96d0fc0
ce0df5f
edea285
ceea0d8
743e33a
87d7cfd
28892d2
78841f4
a4bb0ae
a9bc16a
bc8c29d
1fe54c6
0c3e31a
ff77c97
316b281
ffc5743
f8b3788
662661d
bc2f04f
94a82e3
3024fd8
3444208
93ae015
3172799
b793cae
88df222
a74d440
f6cda43
d362553
491f5a5
5dc1d2f
5f640a9
45f458f
9aa7bcf
4ea6e41
a7b994e
86dbf8f
2b374ef
0b22442
a598923
1b45e04
3083d7f
76da9a2
1fd3476
df6511a
ff6deda
4cfba97
dcf78a2
d0a1d0e
7b239c5
9f9ef23
be809b9
69266c0
a49b3b4
c6f4291
66b26b0
b2d20f5
e36edd8
aed3cc6
e7a5021
ad6e6d4
6f60eae
3a0d8a1
42536dc
f080f0a
02948e0
1b6402c
408d4b4
3272403
eeee01b
28e496d
2e10d52
88def5d
18d00f5
44c7af9
991a58d
cd9d108
e0baaeb
9697be5
211adb0
0e340c9
0cb8208
aacfcab
cedb3a5
7569b72
5f1c684
42fb3bc
f4c343a
7477856
9ede8da
8a16f56
d9ff8b2
3c35f55
9a4c65e
f30d344
3671ed5
b2aecd0
110c499
0a24f0c
2c90e95
13fc1d3
944f4f4
7892ba9
2ebcee2
aa1ab64
962a702
f9bb0d0
ad05473
ffb9a8c
85f3b35
b1c2516
00b069b
d94193c
a638b91
c5adb0c
2ffccb5
8c4f213
56c0322
98aef4e
22d63db
ccdae5c
50fd2ad
b6a216a
db94d0c
ee41d25
a19d639
b380d70
061b8cc
5449c88
f586bce
f90e888
53fba36
8d81239
761eb9d
8619d90
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,11 +46,17 @@ def __init__(self, supplied_backfill: str): | |
super().__init__("Unsupported backfill type", supplied_backfill) | ||
|
||
|
||
def get_snapshot(config: Dict, source_cluster: Cluster): | ||
def get_snapshot(config: Dict, source_cluster: Cluster = None, target_cluster: Cluster = None): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems a bit strange to pass in two clusters to this function given it only operates on one. What about just passing one cluster in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It just uses one cluster to perform any operation. |
||
# Use target_cluster as a fallback when source_cluster is not available | ||
cluster_to_use = source_cluster if source_cluster is not None else target_cluster | ||
|
||
if cluster_to_use is None: | ||
raise ValueError("Either source_cluster or target_cluster must be provided for snapshot operations") | ||
|
||
if 'fs' in config: | ||
return FileSystemSnapshot(config, source_cluster) | ||
return FileSystemSnapshot(config, cluster_to_use) | ||
elif 's3' in config: | ||
return S3Snapshot(config, source_cluster) | ||
return S3Snapshot(config, cluster_to_use) | ||
logger.error(f"An unsupported snapshot type was provided: {config.keys()}") | ||
if len(config.keys()) > 1: | ||
raise UnsupportedSnapshotError(', '.join(config.keys())) | ||
|
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of
__positional__
, would it make sense to have this incommand_root
? Maybe with command_root as an array