Add a check to the frontend to make sure that generated files are tracked or fails the build #1761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e build Signed-off-by: Peter Nied <[email protected]>
peternied
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
peternied
had a problem deploying
to
migrations-cicd
GitHub Actions
Failure
Signed-off-by: Peter Nied <[email protected]>
peternied
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
peternied
had a problem deploying
to
migrations-cicd
GitHub Actions
Failure
…racked Signed-off-by: Peter Nied <[email protected]>
peternied
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
peternied
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
peternied
requested review from
AndreKurait,
chelma,
gregschohn,
jugal-chauhan,
lewijacn,
mikaylathompson and
sumobrian
as code owners
|
|
||
| commandLine 'bash', '-c', ''' | ||
| changed=$(git diff --name-only -- frontend/src/generated/) | ||
| untracked=$(git ls-files --others --exclude-standard -- frontend/src/generated/) |
There was a problem hiding this comment.
Script will check for diff and untracked files, which is good. How will we handle cases where new generated files are added ?
There was a problem hiding this comment.
If the are part of a commit on the branch they will not fail in either of these checks. The nature of the problem is that there were api changes and they didn't got through code review but instead were automatically picked up during the auto-generation process.
| changed=$(git diff --name-only -- frontend/src/generated/) | ||
| untracked=$(git ls-files --others --exclude-standard -- frontend/src/generated/) | ||
| if [ -n "$changed$untracked" ]; then | ||
| echo "Error: Unstaged or untracked files under frontend/src/generated/:" |
There was a problem hiding this comment.
Can we modify the error message to be something like "Please commit the following generated files:..."
There was a problem hiding this comment.
Updated response to include resolution message
> Task :frontend:checkGeneratedFilesTracked FAILED
Error: Unstaged or untracked files under frontend/src/generated/:
frontend/src/generated/api/types.gen.ts
Please run ./gradlew frontend:generateBackendClient and commit the updated files
Signed-off-by: Peter Nied <[email protected]>
…racked Signed-off-by: Peter Nied <[email protected]>
peternied
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
peternied
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
peternied
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
peternied
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
jugal-chauhan
approved these changes
Oct 9, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1761 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a check to the frontend to make sure that generated files are tracked or fails the build
Issues
Check List
Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.