-
Notifications
You must be signed in to change notification settings - Fork 40
Enable Argo based tests for target cluster OS 3.1 #1860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Argo based tests for target cluster OS 3.1 #1860
Conversation
Signed-off-by: Jugal Chauhan <[email protected]>
Signed-off-by: Jugal Chauhan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks largely fine. With this addition of this and ES_6.8 how many combinations will we have? I'm wondering if we want to hold off on adding these to the Jenkins matrix until we add support for running multiple combinations on one worker, say with some minor edits to the test_runner.py
to support say running all target combos for a given source version
I have disabled the Matrix pipeline on jenkins for this newly added target |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1860 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
This PR adds a new target into the Argo based E2E test. This new target
OS_3.1
now supports all available sources and their respective test cases.Issues Resolved
MIGRATIONS-2697
Testing
Locally
pipenv run app --source-version=ES_5.6 --target-version=OS_3.1
pipenv run app --source-version=ES_7.10 --target-version=OS_3.1
Jenkins
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.