[Fix] Create-VPC stack to attach subnets for EKS cluster

[jugal-chauhan]

Description

This PR fixes the EKS VPC stack creation failure in Migration-Assistant-Infra-Create-VPC-v3 by ensuring subnet IDs are properly provided during EKS cluster creation.

When no explicit vpcSubnetIds were passed, only private subnets were included in the subnetIds list, causing EKS cluster creation to fail in certain networking configurations. This caused the stack creation to fail :
Resource handler returned message: "Subnet Id is required (Service: Eks, Status Code: 400)"

Issues Resolved

No Jira

Testing

CFN Stack is CREATE_COMPLETE
Executed using command :

cdk deploy Migration-Assistant-Infra-Create-VPC-v3 \
  --parameters Stage=dev \
  --require-approval never \
  --concurrency 3

Check List

- [ ] New functionality includes testing
- [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[peternied]

Tested this deployment, it failed before, now it works.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (b29166c) to head (c3010ee).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@     Coverage Diff      @@
##   main   #1875   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.