Update RFS default worker config and add initial-lease-duration #1878
+15
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Increase default worker CPU from 2048 to 4096 and memory from 4096 to 8192 - Increase default max-connections from 10 to 20 - Add --initial-lease-duration PT60M parameter to RFS command - Update all tests to reflect new default values Signed-off-by: Andre Kurait <[email protected]>
AndreKurait
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
AndreKurait
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
AndreKurait
requested review from
chelma,
gregschohn,
jugal-chauhan,
lewijacn,
mikaylathompson,
peternied and
sumobrian
as code owners
peternied
reviewed
Oct 10, 2025
| command = appendArgIfNotInExtraArgs(command, extraArgsDict, "--lucene-dir", `"${storagePath}/lucene"`) | ||
| command = appendArgIfNotInExtraArgs(command, extraArgsDict, "--target-host", osClusterEndpoint) | ||
| command = appendArgIfNotInExtraArgs(command, extraArgsDict, "--max-shard-size-bytes", `${Math.ceil(maxShardSizeBytes)}`) | ||
| command = appendArgIfNotInExtraArgs(command, extraArgsDict, "--max-connections", props.reindexFromSnapshotWorkerSize === "maximum" ? "100" : "10") |
There was a problem hiding this comment.
Why is the current minimum too low, shouldn't we advise customers with larger shards to set the size to maximum and avoid tweaking the min values?
peternied
reviewed
Oct 10, 2025
| command = appendArgIfNotInExtraArgs(command, extraArgsDict, "--max-shard-size-bytes", `${Math.ceil(maxShardSizeBytes)}`) | ||
| command = appendArgIfNotInExtraArgs(command, extraArgsDict, "--max-connections", props.reindexFromSnapshotWorkerSize === "maximum" ? "100" : "10") | ||
| command = appendArgIfNotInExtraArgs(command, extraArgsDict, "--max-connections", props.reindexFromSnapshotWorkerSize === "maximum" ? "100" : "20") | ||
| command = appendArgIfNotInExtraArgs(command, extraArgsDict, "--initial-lease-duration", "PT60M") |
There was a problem hiding this comment.
Shouldn't we update the default in the java code rather than cloud formation, this won't be the default on the EKS deployments of RFS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the default configuration for the Reindex from Snapshot (RFS) worker to improve migration performance and reliability:
--initial-lease-duration PT60Mparameter with a 60-minute default to provide more table lease management during migration operationsThese changes apply to the "default" worker size configuration. The "maximum" worker size remains unchanged (16 vCPUs, 32 GB RAM, 100 connections).
Issues Resolved
Seeking to reduce OOM errors and improve performance in the majority of customers.
Testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.