Preprocessing: Handle unnamed additionalProperties - #272
Merged
Conversation
Signed-off-by: xil <fridalu66@gmail.com>
lucy66hw
force-pushed
the
unamed_properties
branch
from
October 30, 2025 18:24
307aab7 to
155b200
Compare
lucy66hw
marked this pull request as ready for review
October 30, 2025 18:26
lucy66hw
requested review from
amberzsy,
karenyrx and
philiplhchan
as code owners
October 30, 2025 18:26
karenyrx
approved these changes
Oct 31, 2025
karenyrx
added a commit
to karenyrx/opensearch-protobufs
that referenced
this pull request
Nov 5, 2025
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: lucy66hw <178352792+lucy66hw@users.noreply.github.com> Preprocessing - handle unamed additionalproperties (opensearch-project#272) Signed-off-by: xil <fridalu66@gmail.com> Protobuf schema change detected (opensearch-project#273) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: lucy66hw <178352792+lucy66hw@users.noreply.github.com> Eliminate file name dependencies in Python generated protobuf code Signed-off-by: Karen X <karenxyr@gmail.com> Merge branch 'main' into pythonfile Signed-off-by: Karen X <karenxyr@gmail.com> simplify by reading proto files instead of generated py files Signed-off-by: Karen X <karenxyr@gmail.com> add unit tests Signed-off-by: Karen X <karenxyr@gmail.com> Address security vulnerabilities (opensearch-project#277) Update dependency @eslint/eslintrc to v3.2.0 (opensearch-project#278) Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Update dependency @eslint/eslintrc to v3.3.0 (opensearch-project#279) Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Update dependency @eslint/eslintrc to v3.3.1 (opensearch-project#281) Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> More security vulnerabilities (opensearch-project#284) Signed-off-by: karenx <karenx@uber.com> Co-authored-by: karenx <karenx@uber.com> Merge remote-tracking branch 'upstream/main' into test123
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preprocessing: Handle unnamed additionalProperties.
in rest APIs, a map type could be used to represent arbitrary key-value pairs.
However, in Protobuf, each field must be explicitly defined within the message.
This change converts schemas with unnamed additionalProperties into explicit message fields to ensure compatibility with Protobuf.
Test
Tested in fork repository: lucy66hw#35