repurpose elasticsearch dense_vector field for knn_vector #925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganondev
requested review from
Shephalimittal,
VachaShah,
axeoman,
dblock,
florianvazelle,
harshavamsi and
saimedhi
as code owners
Signed-off-by: Edward Auttonberry <[email protected]>
saimedhi
approved these changes
Jun 25, 2025
|
No further action is needed from you, @ganondev. The PR will be merged and included in the next release. If an earlier release is needed, please feel free to create an issue requesting it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename DenseVector field type to KnnVector, in the same vein as opensearch-project/opensearch-java#524
Issues Resolved
Similar to opensearch-project/opensearch-java#437
Attribution note
This is a reopening of #853 because I have need of this feature in the near term. Unfortunately I can't do the DCO on behalf of @dannynoonan nor can I amend his fork, so it's all wrapped up under my commit. However I have done the remaining work wrt linting and testing, as well as made a slight modification to the signature to properly reflect the opensearch request.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.