Introduced ResourceObservers when sampling the threads. Extracted metrics calculation #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Extracted logic for taking the threads sample.
Describe the solution you are proposing
Observer is newly introduced component that is responsible for getting the thread metrics details. The component can be used to get:
Also, metric calculation logic is extracted in static method that are grouped in a different classes depending the metric category:
The idea behind this change is to create a re-usable units of the code that will have single responsibility - just to calculate the metrics value based on the provided params.Now, ThreadCPU, ThreadDiskIO and ThreadSched classes are only responsible for:
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.