Skip to content

Conversation

sstults
Copy link

@sstults sstults commented Aug 1, 2025

Description

This PR adds design documentation for #120.

Issues Resolved

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sstults sstults force-pushed the external-evaluation-design branch from 19eafd2 to 8e8c850 Compare August 1, 2025 21:12
@fen-qin
Copy link
Collaborator

fen-qin commented Aug 21, 2025

@sstults @epugh
Thanks for putting so many details in the design documentations.

Would you like to address the following questions ?

  • is there any restriction/validation for external experiment results ?
    • limits on the total payload size
    • the number of evaluation results
    • the size of individual fields.

Would you like to add proper request throttling mechanisms to prevent abuse of the import API ?
Would you like to add proper validation/sanitization to make sure no craft experiment results containing code or scripts that might be executed when viewed or processed ?

I will copy these to implementation PR as well. thanks

@epugh epugh added v3.4.0 and removed v3.3.0 labels Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants