-
Notifications
You must be signed in to change notification settings - Fork 21
Adding capability for remote search #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sstults
wants to merge
13
commits into
opensearch-project:main
Choose a base branch
from
sstults:feature/remote-search-infrastructure
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Adding capability for remote search #235
sstults
wants to merge
13
commits into
opensearch-project:main
from
sstults:feature/remote-search-infrastructure
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added RemoteSearchConfiguration model with validation - Added RemoteSearchCache model for caching search results - Added RemoteSearchFailure model for error tracking - Added corresponding DAO for remote search configuration - Added JSON mappings for all three models - Added comprehensive unit tests for all models - Updated PluginConstants with remote search related constants Signed-off-by: Scott Stults <[email protected]>
Signed-off-by: Scott Stults <[email protected]>
--------- Signed-off-by: Anthony Leong <[email protected]> Co-authored-by: Eric Pugh <[email protected]> Co-authored-by: Daniel Wrigley <[email protected]> Signed-off-by: Scott Stults <[email protected]>
…ct#198) Signed-off-by: Fen Qin <[email protected]> Signed-off-by: Scott Stults <[email protected]>
Signed-off-by: Martin Gaievski <[email protected]> Signed-off-by: Scott Stults <[email protected]>
…ving the --skip-ubi feature (opensearch-project#199) Signed-off-by: Eric Pugh <[email protected]> Signed-off-by: Scott Stults <[email protected]>
…set. (opensearch-project#207) Signed-off-by: wrigleyDan <[email protected]> Signed-off-by: Scott Stults <[email protected]>
…in/CI action (opensearch-project#208) Signed-off-by: Martin Gaievski <[email protected]> Signed-off-by: Scott Stults <[email protected]>
* Add release notes for 3.2.0 Signed-off-by: opensearch-ci <[email protected]> * Update release-notes for 3.2.0 (opensearch-project#210) * Add release notes for 3.2.0 Signed-off-by: opensearch-ci <[email protected]> Signed-off-by: Fen Qin <[email protected]> * clean up CHANGELOG.md Signed-off-by: Fen Qin <[email protected]> --------- Signed-off-by: opensearch-ci <[email protected]> Signed-off-by: Fen Qin <[email protected]> Co-authored-by: opensearch-ci <[email protected]> --------- Signed-off-by: opensearch-ci <[email protected]> Signed-off-by: Fen Qin <[email protected]> Co-authored-by: Fen Qin <[email protected]> Signed-off-by: Scott Stults <[email protected]>
Signed-off-by: Fen Qin <[email protected]> Signed-off-by: Scott Stults <[email protected]>
…h-project#214) * remove docker-compose.yml and update DEVELOPER_GUIDE.md Signed-off-by: wrigleyDan <[email protected]> * Apply suggestions from code review typo fix Signed-off-by: Eric Pugh <[email protected]> --------- Signed-off-by: wrigleyDan <[email protected]> Signed-off-by: Eric Pugh <[email protected]> Co-authored-by: Eric Pugh <[email protected]> Signed-off-by: Scott Stults <[email protected]>
Signed-off-by: Scott Stults <[email protected]>
f7cf0db
to
d4a2000
Compare
Signed-off-by: Scott Stults <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #235 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Remote Query capability extends the Search Relevance plugin to execute search requests against external search systems (e.g., Solr or other OpenSearch clusters) while maintaining a consistent evaluation model. It introduces managed Remote Search Configurations with secure credential handling, per-config rate limiting and concurrency controls, and optional caching to reduce load and improve throughput. Queries are sent over HTTP(S) via a RemoteSearchExecutor, and results are normalized into an OpenSearch-compatible shape by the RemoteResponseMapper, enabling uniform processing regardless of the remote engine’s native response format. The system emphasizes robustness and observability with structured failure tracking, circuit breaker patterns, retries, and new metrics for remote execution performance, failures, and cache effectiveness.
This capability integrates with the existing experiment infrastructure. Experiments continue to use the same query sets, judgment workflows, and metrics (NDCG, MAP, MRR, P@K), and downstream evaluation remains unchanged because responses are normalized before scoring. The design supports side-by-side comparisons of local and remote systems within the standard experiment lifecycle, preserving backward compatibility while enabling cross-platform evaluation scenarios such as migration validation, A/B tests across environments, and multi-vendor benchmarking. This integration allows teams to compare configurations and engines under identical conditions, aggregate results using established indices and reports, and operate within familiar SRW orchestration, APIs, and persistence models.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.