Refactored flaky test. #1467
Merged
Refactored flaky test. #1467
+42
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactored flaky test. Signed-off-by: AWSHurneyt <[email protected]> * Refactored test for flakiness. Signed-off-by: AWSHurneyt <[email protected]> * Updated tests. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 783167a)
AWSHurneyt
requested review from
amsiglan,
eirsep,
engechas,
getsaurabh02,
goyamegh,
jowg-amazon,
lezzago,
praveensameneni,
riysaxen-amzn and
sbcd90
as code owners
Signed-off-by: Subhobrata Dey <[email protected]>
Main ver fix
sbcd90
approved these changes
Feb 6, 2025
eirsep
approved these changes
Feb 6, 2025
|
I still did not understand why we are adding waits? this implies a consistency bug in the system |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://ci.opensearch.org/ci/dbc/integ-test/2.19.0/10772/linux/x64/tar/test-results/9318/integ-test/security-analytics/with-security/opensearch-integ-test/classes/org.opensearch.securityanalytics.alerts.AlertsIT.html#testMultipleAggregationAndDocRules_alertSuccess
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.