Skip to content

fix correlation engine trigger even if no rules are present #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix correlation engine trigger even if no rules are present #1538

wants to merge 1 commit into from

Conversation

sbcd90
Copy link
Collaborator

@sbcd90 sbcd90 commented Jun 10, 2025

Description

fix correlation engine trigger even if no rules are present

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

eirsep
eirsep previously approved these changes Jun 10, 2025
View reviewed changes
Copy link
Member

@eirsep eirsep left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci is failing
change lgtm
can you add a test coverage for your fix

engechas
engechas previously approved these changes Jun 12, 2025
View reviewed changes
@sbcd90 sbcd90 dismissed stale reviews from eirsep and engechas via 308ca6b June 20, 2025 03:46
@sbcd90
fix correlation engine trigger even if no rules are present
fec4832 
Signed-off-by: Subhobrata Dey <[email protected]>

fix integ tests

Signed-off-by: Subhobrata Dey <[email protected]>

fix integ tests

Signed-off-by: Subhobrata Dey <[email protected]>
@eirsep
Copy link
Member

eirsep commented Jun 20, 2025

Why are we not checking in first line if not (rule index exists and autocorrelation disabled) just return 200?
I wrote a test on this PR to see if correlation index is created inspite of no rules and disabled autocorrealtions; and it gets created while i was expecting no disk writes would happen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eirsep eirsep eirsep left review comments

@engechas engechas engechas left review comments

@amsiglan amsiglan Awaiting requested review from amsiglan amsiglan is a code owner

@AWSHurneyt AWSHurneyt Awaiting requested review from AWSHurneyt AWSHurneyt is a code owner

@getsaurabh02 getsaurabh02 Awaiting requested review from getsaurabh02 getsaurabh02 is a code owner

@lezzago lezzago Awaiting requested review from lezzago lezzago is a code owner

@praveensameneni praveensameneni Awaiting requested review from praveensameneni praveensameneni is a code owner

@jowg-amazon jowg-amazon Awaiting requested review from jowg-amazon jowg-amazon is a code owner

@goyamegh goyamegh Awaiting requested review from goyamegh goyamegh is a code owner

@riysaxen-amzn riysaxen-amzn Awaiting requested review from riysaxen-amzn riysaxen-amzn is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sbcd90 @eirsep @engechas