fix correlation engine trigger even if no rules are present #1545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eirsep
requested review from
AWSHurneyt,
amsiglan,
engechas,
getsaurabh02,
goyamegh,
jowg-amazon,
lezzago,
praveensameneni,
riysaxen-amzn and
sbcd90
as code owners
engechas
reviewed
Jun 20, 2025
src/main/java/org/opensearch/securityanalytics/transport/TransportCorrelateFindingAction.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/securityanalytics/mapper/MapperRestApiIT.java
Show resolved
Hide resolved
sbcd90
previously approved these changes
Jun 20, 2025
Signed-off-by: Subhobrata Dey <[email protected]>
…s without rules and auto correlations Signed-off-by: Surya Sashank Nistala <[email protected]>
…o correlations Signed-off-by: Surya Sashank Nistala <[email protected]>
…d no auto correlations" This reverts commit cbf944f.
Signed-off-by: Surya Sashank Nistala <[email protected]>
engechas
approved these changes
Jun 20, 2025
sbcd90
approved these changes
Jun 20, 2025
riysaxen-amzn
approved these changes
Jun 20, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 20, 2025
* fix correlation engine trigger even if no rules are present Signed-off-by: Subhobrata Dey <[email protected]> * remove index pattern related tests and add test to verify correlations without rules and auto correlations Signed-off-by: Surya Sashank Nistala <[email protected]> * check and short circuit correlation evaluation if no rules and no auto correlations Signed-off-by: Surya Sashank Nistala <[email protected]> * Revert "check and short circuit correlation evaluation if no rules and no auto correlations" This reverts commit cbf944f. * remove non-empty correlation index check Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Subhobrata Dey <[email protected]> Signed-off-by: Surya Sashank Nistala <[email protected]> Co-authored-by: Subhobrata Dey <[email protected]> (cherry picked from commit 2a1014d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 20, 2025
* fix correlation engine trigger even if no rules are present Signed-off-by: Subhobrata Dey <[email protected]> * remove index pattern related tests and add test to verify correlations without rules and auto correlations Signed-off-by: Surya Sashank Nistala <[email protected]> * check and short circuit correlation evaluation if no rules and no auto correlations Signed-off-by: Surya Sashank Nistala <[email protected]> * Revert "check and short circuit correlation evaluation if no rules and no auto correlations" This reverts commit cbf944f. * remove non-empty correlation index check Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Subhobrata Dey <[email protected]> Signed-off-by: Surya Sashank Nistala <[email protected]> Co-authored-by: Subhobrata Dey <[email protected]> (cherry picked from commit 2a1014d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 20, 2025
* fix correlation engine trigger even if no rules are present Signed-off-by: Subhobrata Dey <[email protected]> * remove index pattern related tests and add test to verify correlations without rules and auto correlations Signed-off-by: Surya Sashank Nistala <[email protected]> * check and short circuit correlation evaluation if no rules and no auto correlations Signed-off-by: Surya Sashank Nistala <[email protected]> * Revert "check and short circuit correlation evaluation if no rules and no auto correlations" This reverts commit cbf944f. * remove non-empty correlation index check Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Subhobrata Dey <[email protected]> Signed-off-by: Surya Sashank Nistala <[email protected]> Co-authored-by: Subhobrata Dey <[email protected]> (cherry picked from commit 2a1014d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
eirsep
pushed a commit
that referenced
this pull request
Jun 20, 2025
…1546) * fix correlation engine trigger even if no rules are present * remove index pattern related tests and add test to verify correlations without rules and auto correlations * check and short circuit correlation evaluation if no rules and no auto correlations * Revert "check and short circuit correlation evaluation if no rules and no auto correlations" This reverts commit cbf944f. * remove non-empty correlation index check --------- (cherry picked from commit 2a1014d) Signed-off-by: Subhobrata Dey <[email protected]> Signed-off-by: Surya Sashank Nistala <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Subhobrata Dey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helping to merge @sbcd90's https://github.com/opensearch-project/security-analytics/pull/1538/files and fix CI