Use instance of LockService instantiated in JobScheduler through Guice #1555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
AWSHurneyt,
amsiglan,
eirsep,
engechas,
getsaurabh02,
goyamegh,
jowg-amazon,
lezzago,
praveensameneni,
riysaxen-amzn and
sbcd90
as code owners
Signed-off-by: Craig Perkins <[email protected]>
|
Test failures appear related to opensearch-project/common-utils#829. I'll take a deeper dive to see what's required to fix the tests. |
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
|
Can a maintainer please help take a look at this PR? I had to mute 2 tests that were failing due to opensearch-project/common-utils#829 in common-utils. |
AWSHurneyt
approved these changes
Jul 16, 2025
eirsep
approved these changes
Jul 18, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Companion JS PR: opensearch-project/job-scheduler#670
This PR shows how SAP can be refactored to use the instance of the LockService that is initialized in Job Scheduler's
createComponents.This PR is part of an effort to remove usages of
ThreadContext.stashContextacross the plugins: opensearch-project/opensearch-plugins#238Currently, security analytics instantiates its own instance of the LockService by passing in the Client given to analytics through
createComponents.As part of the effort to Strengthen System Indices in the Plugin Ecosystem, plugins will be restricted to only perform transport actions to their own system indices. This PR is to ensure that SAP uses the LockService instantiated by JS (which has permission to JS system indices) vs creating its own LockService.
Related Issues
Related to opensearch-project/security#4439
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.