Ensure that user attributes are in expected format attrKey=attrVal for testing #1583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r testing Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
AWSHurneyt,
amsiglan,
eirsep,
engechas,
getsaurabh02,
goyamegh,
jowg-amazon,
lezzago,
praveensameneni,
riysaxen-amzn and
sbcd90
as code owners
Signed-off-by: Craig Perkins <[email protected]>
AWSHurneyt
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Many repos have a user attribute called
custom_attribute_namesthat is in their system index mappings when storing a copy of the user. This field exists, but was never plumbed rendering this field as useless.There is a bugfix underway to fix an issue in the alerting repo when an alerting monitor is created by a user that has DLS restrictions that have user attribute substitutions. As part of fixing the bug, the field
custom_attribute_nameswill now be used and each entry in the list is expected to be in theattrKey=attrValformat. This PR ensures that test data that the security-analytics plugin creates conforms to this expected format.Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.