[Backport 2.19] Move rules to config directory from classpath resources (#1580) #1584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roject#1580) * Remove direct reference to Job-Scheduler Lock Index in SAP repo Signed-off-by: Craig Perkins <[email protected]> * Exclude error_prone_annotations from locally checked in shadow jar for commons Signed-off-by: Craig Perkins <[email protected]> * Include apache httpcomponents Signed-off-by: Craig Perkins <[email protected]> * Move rules to config directory from classpath resources Signed-off-by: Craig Perkins <[email protected]> * Fix tests Signed-off-by: Craig Perkins <[email protected]> * Read from path directly Signed-off-by: Craig Perkins <[email protected]> * Fix prepackaged rules test Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 95dd123)
cwperks
requested review from
AWSHurneyt,
amsiglan,
eirsep,
engechas,
getsaurabh02,
goyamegh,
jowg-amazon,
lezzago,
praveensameneni,
riysaxen-amzn and
sbcd90
as code owners
|
Needs companion core PR to be merged first: opensearch-project/OpenSearch#19418 |
Signed-off-by: Craig Perkins <[email protected]>
riysaxen-amzn
approved these changes
Oct 10, 2025
engechas
approved these changes
Oct 10, 2025
riysaxen-amzn
merged commit 2ae79a6
into
opensearch-project:2.19
16 of 26 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 95dd123)
Description
Backport #1580 to 2.19.
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.