Skip to content

Conversation

derek-ho
Copy link
Collaborator

Description

[Describe what this change achieves]

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
  • Why these changes are required?
  • What is the old behavior before changes and new behavior after changes?

Issues Resolved

[List any issues this PR will resolve]

Is this a backport? If so, please add backport PR # and/or commits #, and remove backport-failed label from the original PR.

Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 63.75321% with 282 lines in your changes missing coverage. Please review.

Project coverage is 71.42%. Comparing base (e4053bc) to head (8750e8b).
Report is 134 commits behind head on main.

Files with missing lines Patch % Lines
...arch/security/action/apitokens/ApiTokenAction.java 22.64% 118 Missing and 5 partials ⚠️
...pensearch/security/http/ApiTokenAuthenticator.java 58.97% 22 Missing and 10 partials ⚠️
...ensearch/security/privileges/ActionPrivileges.java 78.00% 12 Missing and 10 partials ⚠️
...urity/action/apitokens/ApiTokenUpdateResponse.java 0.00% 14 Missing ⚠️
...ction/apitokens/TransportApiTokenUpdateAction.java 22.22% 14 Missing ⚠️
...ecurity/action/apitokens/ApiTokenIndexHandler.java 81.81% 10 Missing ⚠️
...opensearch/security/action/apitokens/ApiToken.java 91.20% 2 Missing and 6 partials ⚠️
...search/security/identity/SecurityTokenManager.java 86.79% 4 Missing and 3 partials ⚠️
...es/PermissionBasedPrivilegesEvaluationContext.java 36.36% 7 Missing ⚠️
...curity/action/apitokens/ApiTokenUpdateRequest.java 0.00% 6 Missing ⚠️
... and 13 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5225      +/-   ##
==========================================
- Coverage   71.70%   71.42%   -0.28%     
==========================================
  Files         337      355      +18     
  Lines       22783    23481     +698     
  Branches     3604     3688      +84     
==========================================
+ Hits        16336    16772     +436     
- Misses       4646     4875     +229     
- Partials     1801     1834      +33     
Files with missing lines Coverage Δ
.../opensearch/security/OpenSearchSecurityPlugin.java 83.96% <100.00%> (+0.13%) ⬆️
...ecurity/action/apitokens/ApiTokenUpdateAction.java 100.00% <100.00%> (ø)
...g/opensearch/security/authtoken/jwt/JwtVendor.java 83.33% <100.00%> (-5.76%) ⬇️
...rity/authtoken/jwt/claims/ApiJwtClaimsBuilder.java 100.00% <100.00%> (ø)
...ensearch/security/compliance/ComplianceConfig.java 89.17% <100.00%> (+0.06%) ⬆️
...rg/opensearch/security/dlic/rest/api/Endpoint.java 100.00% <100.00%> (ø)
...dlic/rest/api/RestApiAdminPrivilegesEvaluator.java 73.07% <100.00%> (+0.52%) ⬆️
...curity/privileges/PrivilegesEvaluationContext.java 100.00% <100.00%> (+2.70%) ⬆️
...ch/security/securityconf/DynamicConfigFactory.java 62.74% <100.00%> (+0.24%) ⬆️
...arch/security/securityconf/DynamicConfigModel.java 100.00% <ø> (ø)
... and 26 more

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dkumar-cr
Copy link

Hi @derek-ho,

I have been eagerly awaiting this feature for quite some time. Could you please share if it is planned for release soon, or if it might take longer? If it will be included in any upcoming release, that would be great to know; otherwise, I’ll explore alternative solutions.

I would appreciate any update you can provide.

Thank you!

@DarshitChanpura
Copy link
Member

Closing in lieu of #5443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants