-
Notifications
You must be signed in to change notification settings - Fork 336
Make user attribute serialization property dynamic #5673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cwperks
merged 9 commits into
opensearch-project:main
from
cwperks:make-user-attribute-serialization-property-dynamic
Oct 1, 2025
Merged
Make user attribute serialization property dynamic #5673
cwperks
merged 9 commits into
opensearch-project:main
from
cwperks:make-user-attribute-serialization-property-dynamic
Oct 1, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ization.enabled dynamic Signed-off-by: Mark Boyd <[email protected]>
Signed-off-by: Mark Boyd <[email protected]>
Signed-off-by: Mark Boyd <[email protected]>
…er() Signed-off-by: Mark Boyd <[email protected]>
Signed-off-by: Mark Boyd <[email protected]>
…o SecuritySetting Signed-off-by: Mark Boyd <[email protected]>
…ther user attribute serialization is enabled Signed-off-by: Mark Boyd <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM. left one comment. Will approve once addressed
Signed-off-by: Craig Perkins <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5673 +/- ##
==========================================
- Coverage 72.97% 72.93% -0.04%
==========================================
Files 414 414
Lines 25873 25902 +29
Branches 3934 3934
==========================================
+ Hits 18881 18892 +11
- Misses 5079 5098 +19
+ Partials 1913 1912 -1
🚀 New features to boost your workflow:
|
DarshitChanpura
approved these changes
Oct 1, 2025
RyanL1997
approved these changes
Oct 1, 2025
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-creating #5657 with a test fix.
This PR makes the configuration setting for
plugins.security.user_attribute_serialization.enabled
dynamic, so it can be updated via requests toPUT cluster/_settings
.opensearch.yml
. After: The setting can be dynamically updated with requests toPUT cluster/_settings
.Issues Resolved
Is this a backport? If so, please add backport PR # and/or commits #, and remove
backport-failed
label from the original PR.Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here
Testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.