-
Notifications
You must be signed in to change notification settings - Fork 336
[Resource Sharing] Makes resource settings dynamic #5677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DarshitChanpura
wants to merge
21
commits into
opensearch-project:main
Choose a base branch
from
DarshitChanpura:dynamic-resource-settings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Resource Sharing] Makes resource settings dynamic #5677
DarshitChanpura
wants to merge
21
commits into
opensearch-project:main
from
DarshitChanpura:dynamic-resource-settings
+1,726
−1,041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
This was referenced Oct 2, 2025
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
… as protected and fixes share api action to throw 400 on resources not marked as protected Signed-off-by: Darshit Chanpura <[email protected]>
…consume new changes Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
cwperks
reviewed
Oct 9, 2025
src/main/java/org/opensearch/security/resources/ResourceIndexListener.java
Show resolved
Hide resolved
cwperks
reviewed
Oct 9, 2025
...src/integrationTest/java/org/opensearch/sample/resource/feature/FeatureFlagSettingTests.java
Show resolved
Hide resolved
cwperks
previously approved these changes
Oct 9, 2025
Signed-off-by: Darshit Chanpura <[email protected]>
…ad-safe in resource-plugin-info class Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
cwperks
reviewed
Oct 13, 2025
src/main/java/org/opensearch/security/configuration/DlsFlsValveImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Darshit Chanpura <[email protected]>
cwperks
approved these changes
Oct 13, 2025
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes resource sharing settings dynamic. Also adds capability for plugin to chose codepath based on protected resource-types
Issues Resolved
TBD
Testing
Manual + Automated Testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.