Skip to content

Conversation

DarshitChanpura
Copy link
Member

Description

Makes resource sharing settings dynamic. Also adds capability for plugin to chose codepath based on protected resource-types

  • Category : Enhancement
  • Why these changes are required?
  • To allow settings to be update-able by customers through cluster-settings API

Issues Resolved

TBD

Testing

Manual + Automated Testing

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@DarshitChanpura DarshitChanpura added the resource-permissions Label to track all items related to resource permissions label Oct 2, 2025
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 89.39394% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.88%. Comparing base (d2365fb) to head (f9fb61a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...search/security/configuration/DlsFlsValveImpl.java 27.27% 7 Missing and 1 partial ⚠️
...nsearch/security/resources/ResourcePluginInfo.java 94.59% 0 Missing and 4 partials ⚠️
.../actions/transport/GetResourceTransportAction.java 66.66% 2 Missing ⚠️
...ecurity/resources/ResourceAccessControlClient.java 60.00% 2 Missing ⚠️
...ources/api/list/AccessibleResourcesRestAction.java 33.33% 1 Missing and 1 partial ⚠️
...ty/resources/api/list/ResourceTypesRestAction.java 60.00% 1 Missing and 1 partial ⚠️
...h/security/privileges/ResourceAccessEvaluator.java 85.71% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5677      +/-   ##
==========================================
- Coverage   72.93%   72.88%   -0.05%     
==========================================
  Files         420      412       -8     
  Lines       26269    26208      -61     
  Branches     3974     3964      -10     
==========================================
- Hits        19159    19102      -57     
- Misses       5192     5198       +6     
+ Partials     1918     1908      -10     
Files with missing lines Coverage Δ
...va/org/opensearch/sample/SampleResourcePlugin.java 95.65% <ø> (-0.65%) ⬇️
.../opensearch/security/OpenSearchSecurityPlugin.java 85.39% <100.00%> (-0.17%) ⬇️
...arch/security/resources/ResourceIndexListener.java 96.15% <100.00%> (+1.28%) ⬆️
.../security/resources/api/share/ShareRestAction.java 100.00% <100.00%> (+6.66%) ⬆️
...es/settings/ResourceSharingFeatureFlagSetting.java 100.00% <100.00%> (ø)
...ings/ResourceSharingProtectedResourcesSetting.java 100.00% <100.00%> (ø)
...opensearch/security/rest/DashboardsInfoAction.java 82.00% <100.00%> (-0.36%) ⬇️
...rch/security/setting/OpensearchDynamicSetting.java 60.00% <ø> (ø)
...h/security/privileges/ResourceAccessEvaluator.java 64.51% <85.71%> (ø)
.../actions/transport/GetResourceTransportAction.java 93.54% <66.66%> (+5.66%) ⬆️
... and 5 more

... and 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cwperks cwperks changed the title Makes resource settings dynamic [Resource Sharing] Makes resource settings dynamic Oct 9, 2025
cwperks
cwperks previously approved these changes Oct 9, 2025
@cwperks cwperks dismissed their stale review October 9, 2025 20:24

Failing tests

Signed-off-by: Darshit Chanpura <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

resource-permissions Label to track all items related to resource permissions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants