Switch guava deps from compileOnly to implementation #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
Zhangxunmt,
amitgalitz,
b4sjoo,
dbwiddis,
dhrubo-os,
eirsep,
jackiehanyang,
jngz-es,
joshpalis,
joshuali925,
kaituo,
lezzago,
model-collapse,
ohltyler,
owaiskazi19,
rbhavna,
sbcd90,
xinyual,
ylwu-amzn,
zane-neo and
zhichao-aws
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
skills has its guava dependencies set at compileOnly level which means they are not packaged into the skills assembly and available at runtime.
skills uses these deps at runtime, however, the way this works is because of the extending relationship between skills and JS plugin where the deps of the extended plugin are available to the extending plugin at runtime.
In opensearch-project/job-scheduler#773, guava was removed from JS which means these deps are no longer available to skills at runtime. I'm creating this PR to change the guava deps from compileOnly to implementation to ensure they are included in the assembly and available at runtime.
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.