fix!: dashboard object created in wrong index #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: removal of `index` default forces replacement when only `tenant_name` was used or `index` was not set. Signed-off-by: Manuel Rapp <[email protected]>
Manuelraa
requested review from
jackson-theisen,
peterzhuamazon,
phillbaker,
prudhvigodithi and
rblcoder
as code owners
Signed-off-by: Manuel Rapp <[email protected]>
|
Dear maintainers (@peterzhuamazon, @prudhvigodithi, @jackson-theisen, @phillbaker, @rblcoder), could you have a look please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: removal of
indexdefault forces replacement when onlytenant_namewas used orindexwas not set.Description
This fix ensures index patterns are created in the correct index. The previous logic was buggy when using
tenant_name.When doing the lookup for existing resource the provider always used
.kibanaindex which is wrong when usingtenant_name.Issues Resolved
No existing issue.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.