Gh 26 switch to official sdk#283
Draft
zampettim wants to merge 12 commits intoopensearch-project:mainfrom
Draft
Conversation
zampettim
force-pushed
the
gh-26-switch-to-official-sdk
branch
from
991bc11 to
6c8e4e4
Compare
Signed-off-by: Marc Zampetti <zampettim@users.noreply.github.com>
Signed-off-by: Marc Zampetti <zampettim@users.noreply.github.com>
Signed-off-by: Marc Zampetti <zampettim@users.noreply.github.com>
Signed-off-by: Marc Zampetti <zampettim@users.noreply.github.com>
Signed-off-by: Marc Zampetti <zampettim@users.noreply.github.com>
Migrated resources: - component_template.go - composable_index_template.go - index_template.go - data_stream.go - dashboard_tenant.go - snapshot_repository.go - cluster_settings.go - script.go - ingest_pipeline.go (with SDK limitation workaround) Also updated: - data_stream_test.go helper functions - ingest_pipeline_test.go to use new SDK client - Added comment documenting ingest pipeline SDK limitation All migrated resources now use getOpenSearchClient() and opensearch-go/v4 API calls instead of olivere/elastic. Known limitation: Ingest pipeline uses raw HTTP due to SDK struct missing 'version' field (documented in code comment). Signed-off-by: Marc Zampetti <zampettim@users.noreply.github.com>
…edge cases, but need to be addressed. Signed-off-by: Marc Zampetti <zampettim@users.noreply.github.com>
Signed-off-by: Marc Zampetti <zampettim@users.noreply.github.com>
zampettim
force-pushed
the
gh-26-switch-to-official-sdk
branch
from
6c8e4e4 to
a8fcd0e
Compare
… client Signed-off-by: Marc Zampetti <zampettim@users.noreply.github.com>
Signed-off-by: Marc Zampetti <zampettim@users.noreply.github.com>
…1.24 Signed-off-by: Marc Zampetti <zampettim@users.noreply.github.com>
…arch into opensearch-projectgh-26-switch-to-official-sdk Signed-off-by: Marc Zampetti <zampettim@users.noreply.github.com>
zampettim
requested review from
jackson-theisen,
peterzhuamazon,
phillbaker,
prudhvigodithi and
rblcoder
as code owners
Author
|
Converting this back to draft while I review few things I've found as I continue on this effort. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates to use the official opensearch-go/v4 SDK as well as moves to the aws-go-sdk-V2.
All of the tests are passing, and from what I can see, the functionality remains the same.
Issues Resolved
gh-26 and gh-151
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.