Add "descendingOrder" parameter to filters and CSAPI #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
No worries about H2. I think we can do the reverse iteration easily even in this version. |
Author
|
I just changed the initial TemporalFilter's range from Range.all(); to Range.open(Instant.MIN, Instant.MAX); and it is working now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the descendingOrder parameter to TemporalFilter, which can be used to sort observations, commands, and command statuses. One note is that we cannot currently have an efficient implementation in H2 without upgrading our H2 version, as the newer version of H2's Cursor supports reverse iteration efficiently.