Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.16] Thread safeness (backport) #1355

Open
wants to merge 2 commits into
base: release-v1.16
Choose a base branch
from

Conversation

matzew
Copy link
Member

@matzew matzew commented Nov 6, 2024

Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@creydr
Copy link
Member

creydr commented Nov 6, 2024

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 820080b and 2 for PR HEAD b1d8402 in total

@matzew
Copy link
Member Author

matzew commented Nov 7, 2024

/retest

1 similar comment
@matzew
Copy link
Member Author

matzew commented Nov 7, 2024

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 820080b and 2 for PR HEAD b1d8402 in total

@matzew
Copy link
Member Author

matzew commented Nov 8, 2024

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 820080b and 2 for PR HEAD b1d8402 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 820080b and 2 for PR HEAD b1d8402 in total

@matzew
Copy link
Member Author

matzew commented Nov 11, 2024 via email

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 820080b and 2 for PR HEAD b1d8402 in total

3 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 820080b and 2 for PR HEAD b1d8402 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 820080b and 2 for PR HEAD b1d8402 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 820080b and 2 for PR HEAD b1d8402 in total

@matzew
Copy link
Member Author

matzew commented Nov 13, 2024

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 820080b and 2 for PR HEAD b1d8402 in total

4 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 820080b and 2 for PR HEAD b1d8402 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 820080b and 2 for PR HEAD b1d8402 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 820080b and 2 for PR HEAD b1d8402 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 820080b and 2 for PR HEAD b1d8402 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 35b5e78 and 2 for PR HEAD b1d8402 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 35b5e78 and 2 for PR HEAD b1d8402 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f012102 and 1 for PR HEAD b1d8402 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f012102 and 2 for PR HEAD b1d8402 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5f89e62 and 1 for PR HEAD b1d8402 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5f89e62 and 2 for PR HEAD b1d8402 in total

6 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5f89e62 and 2 for PR HEAD b1d8402 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5f89e62 and 2 for PR HEAD b1d8402 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5f89e62 and 2 for PR HEAD b1d8402 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5f89e62 and 2 for PR HEAD b1d8402 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5f89e62 and 2 for PR HEAD b1d8402 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5f89e62 and 2 for PR HEAD b1d8402 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6af97d8 and 2 for PR HEAD b1d8402 in total

12 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6af97d8 and 2 for PR HEAD b1d8402 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6af97d8 and 2 for PR HEAD b1d8402 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6af97d8 and 2 for PR HEAD b1d8402 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6af97d8 and 2 for PR HEAD b1d8402 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6af97d8 and 2 for PR HEAD b1d8402 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6af97d8 and 2 for PR HEAD b1d8402 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6af97d8 and 2 for PR HEAD b1d8402 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6af97d8 and 2 for PR HEAD b1d8402 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6af97d8 and 2 for PR HEAD b1d8402 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6af97d8 and 2 for PR HEAD b1d8402 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6af97d8 and 2 for PR HEAD b1d8402 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6af97d8 and 2 for PR HEAD b1d8402 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3c071c1 and 1 for PR HEAD b1d8402 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e48e623 and 0 for PR HEAD b1d8402 in total

@openshift-ci-robot
Copy link

/hold

Revision b1d8402 was retested 3 times: holding

Copy link

openshift-ci bot commented Dec 13, 2024

@matzew: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/417-test-reconciler-aws-417 b1d8402 link true /test 417-test-reconciler-aws-417
ci/prow/417-test-conformance-aws-417 b1d8402 link true /test 417-test-conformance-aws-417
ci/prow/417-test-reconciler-keda-aws-417 b1d8402 link true /test 417-test-reconciler-keda-aws-417
ci/prow/417-test-reconciler-encryption-auth-aws-417 b1d8402 link true /test 417-test-reconciler-encryption-auth-aws-417
ci/prow/417-test-e2e-aws-417 b1d8402 link true /test 417-test-e2e-aws-417
ci/prow/417-test-conformance b1d8402 link true /test 417-test-conformance
ci/prow/417-test-reconciler b1d8402 link true /test 417-test-reconciler
ci/prow/417-test-e2e b1d8402 link true /test 417-test-e2e
ci/prow/417-test-reconciler-keda b1d8402 link true /test 417-test-reconciler-keda
ci/prow/417-test-reconciler-encryption-auth b1d8402 link true /test 417-test-reconciler-encryption-auth

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants