[release-v1.17] fix: PaC does not refer tekton hub #1438
Conversation
Signed-off-by: Matej Vašek <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
matejvasek
changed the title
|
@matejvasek: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| gct, err := getGitCloneTask() | ||
| if err != nil { | ||
| return fmt.Errorf("error getting git clone task: %v", err) | ||
| } | ||
| gts, err := getTaskSpec(gct) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
This is just quick fix for 1.37.1 patch release. To properly unit test it would require a lot more re-work. We might not have enough time for that.
This branch will probably be dead after the release. No point to have test for regression.
twoGiants
left a comment
twoGiants
left a comment
There was a problem hiding this comment.
Great that you removed the hub reference! 😸 👍
Now there is new logic with error handling. Usually I'd say this needs unit tests to cover it. Wdys in this case?
|
@jrangelramos please verify that this works. |
@twoGiants Wrt test for errors in general: I do not find it very useful for "non actionable/recoverable" errors. I mean errors where there is nothing to be done -- you either interrupt/crash whole app or just print warning. OK I mean it's good to check we are not ignoring any error but it is quite well done in Go IMO. Go forces you to check errors by design, so there is little change there is unhandled error. However I think they are very much useful when we return "sentinel" error which value is subsequently test using |
|
it works. it looks good to me |
No description provided.