Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Check for empty pull-secrets #3117

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🐛 Check for empty pull-secrets #3117

wants to merge 1 commit into from

Conversation

cardil
Copy link
Member

@cardil cardil commented Dec 3, 2024

Proposed Changes

  • 🐛 Check for empty pull-secrets on catalog-source pod

/kind bug

Ref.: https://redhat-internal.slack.com/archives/CLUCMK7R6/p1733249078088419

@cardil cardil requested a review from mgencur December 3, 2024 18:42
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 3, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the kind/bug Something isn't working label Dec 3, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cardil
Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cardil cardil changed the title Check for empty pull-secrets 🐛 Check for empty pull-secrets Dec 3, 2024
@cardil
Copy link
Member Author

cardil commented Dec 3, 2024

/test 417-operator-e2e

@cardil cardil force-pushed the bugfix/jfne-catalogsource-dockercfg-pullsecret branch 2 times, most recently from fbf0056 to 6dd53f9 Compare December 3, 2024 19:24
@cardil
Copy link
Member Author

cardil commented Dec 3, 2024

/test 417-operator-e2e

@cardil cardil force-pushed the bugfix/jfne-catalogsource-dockercfg-pullsecret branch 2 times, most recently from 2b0700f to 8fbcaa1 Compare December 4, 2024 09:26
@cardil cardil force-pushed the bugfix/jfne-catalogsource-dockercfg-pullsecret branch from 8fbcaa1 to 9f1175a Compare December 4, 2024 10:40
@cardil
Copy link
Member Author

cardil commented Dec 4, 2024

/test all

@cardil cardil marked this pull request as ready for review December 6, 2024 17:57
@openshift-ci openshift-ci bot requested review from pierDipi and rhuss December 6, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgencur mgencur Awaiting requested review from mgencur

@pierDipi pierDipi Awaiting requested review from pierDipi

@rhuss rhuss Awaiting requested review from rhuss

Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cardil