Refactor/ipa telco kpis prow migration report generation#464
Merged
openshift-merge-bot[bot] merged 1 commit intoJun 24, 2026
Conversation
d3b9035 to
a594da3
Compare
96334b8 to
89137f7
Compare
a95c39f to
77229c2
Compare
eifrach
requested changes
Jun 24, 2026
Comment on lines
+290
to
+300
| - name: Run analyze-podman-test-results.py in test-runner container | ||
| ansible.builtin.shell: | | ||
| podman run --rm \ | ||
| -v {{ shared_artifact_dir }}:/reports/podman-runs:ro,Z \ | ||
| -v {{ shared_artifact_dir }}:/reports/rds-compare:ro,Z \ | ||
| -v {{ temp_output_dir.path }}:/workspace/output:rw,Z \ | ||
| telco-kpis-test-runner:latest \ | ||
| python3.11 /opt/analyze-podman-test-results.py {{ python_args }} | ||
| register: report_result | ||
| failed_when: report_result.rc != 0 | ||
| changed_when: false |
Collaborator
There was a problem hiding this comment.
I think you should use the podman module here
Implement aggregated test report generation system that combines all Telco-KPIs
test results into comprehensive Markdown reports with Gitea publishing.
## Playbook
**playbooks/telco-kpis/generate-report.yml:**
- Aggregates artifacts from shared location: `/home/telcov10n/telco-kpis-artifacts/{spoke}/`
- Runs analyze-podman-test-results.py in telco-kpis-test-runner container
- Filters tests based on node-info timestamp (freshness check)
- Integrates ZTP deployment timeline into report
- Publishes Markdown report + compressed tarball to Gitea repository
## Features
**Test Freshness Check:**
- Compares test timestamps against node-info baseline
- Skips report generation if no new tests since last report
- Ensures reports only include tests from current environment configuration
**Timestamp-Based Filtering:**
- All tests use UTC timestamps: `{test-name}-{spoke}-{YYYYMMDD-HHMMSS}`
- Report generation filters out stale tests from previous deployments
- Prevents mixing results from different cluster configurations
**Report Components:**
- Hardware metadata (from collect-node-info)
- Performance test results (oslat, cyclictest, ptp, cpu_util, reboot)
- BIOS validation results
- RDS comparison
- ZTP deployment timeline (inserted before "Report Metadata" section)
- RFC2544 network performance
**Gitea Integration:**
- Publishes to Gitea repository via gitea role
- Creates timestamped release with artifacts tarball
- Updates repository README with latest report links
- Implements retention policy (keeps last 15 reports)
## Implementation Details
**Task:** `tasks/generate-report.yml`
**Artifact Directory Pattern:**
```
/home/telcov10n/telco-kpis-artifacts/{spoke}/
├── node-info-{spoke}.json # Baseline
├── {test-name}-{spoke}-{YYYYMMDD-HHMMSS}/ # Tests
│ ├── junit_{test-name}.xml
│ └── {test-specific-artifacts}
```
**Report Action Logic:**
- `create`: Generate new report (node-info exists, tests newer than last report)
- `update`: Regenerate with fresh tests
- `skip`: No new tests since last report
**Container Execution:**
- Uses telco-kpis-test-runner:latest
- Mounts shared artifact base to /reports/podman-runs
- Runs analyze-podman-test-results.py with spoke filter
- Outputs to temporary directory for Gitea publishing
## UTC Timestamp Consistency
All telco-kpis tests use UTC timestamps to ensure correct chronological ordering
and freshness comparison across different bastion timezones.
## Benefits
- Single comprehensive report per spoke cluster
- Automatic staleness detection prevents mixing results
- Gitea hosting provides accessible web UI for stakeholders
- Retention policy prevents unbounded storage growth
- Git-based versioning of historical reports
Related: Telco-KPIs test infrastructure, Gitea deployment
Signed-off-by: Carlos Cardenosa <ccardeno@redhat.com>
77229c2 to
ea5f322
Compare
Collaborator
|
/lgm |
Collaborator
|
/lgtm |
Collaborator
Author
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccardenosa The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.