modified kubevirt scripts to use populators - #16
Conversation
|
This looks good from my side. |
|
@elfosardo I could not add reviewers to this PR. Can you review it and possibly merge it if its ok? |
jobbler
changed the title
| @@ -1,5 +1,5 @@ | |||
| FROM registry.fedoraproject.org/fedora-minimal:40 | |||
| MAINTAINER Mario Vazquez <mavazque@redhat.com> | |||
| MAINTAINER https://github.com/openshift-metal3/fakefish | |||
There was a problem hiding this comment.
this doesn't look like part of this change
There was a problem hiding this comment.
were you wanting this changed back to Mario? I set it to the project since it was updated and did not know if he wanted his name there still. I can change it back if desired. makes no difference to the functionality.
There was a problem hiding this comment.
I guess we don't have a good value to put here..
|
Hi, can we get this merged in, please? It's been sitting for a while; currently I need to cherry pick this PR to get things working. I can verify it's needed. Thank you. |
| oc -n ${VM_NAMESPACE} patch vm ${VM_NAME} --patch-file /tmp/${VM_NAME}.patch --type json | ||
| if [ $? -eq 0 ]; then | ||
| oc -n ${VM_NAMESPACE} delete configmap ${VM_NAME}-iso-ca &> /dev/null | ||
| #oc -n ${VM_NAMESPACE} delete configmap ${VM_NAME}-iso-ca &> /dev/null |
There was a problem hiding this comment.
Was this left commented out on purpose? If it's not needed, let's remove it entirely.
There was a problem hiding this comment.
@jobbler could you remove these comments so we can get this merged?
There was a problem hiding this comment.
@mvazquezc sorry, I did not see this request. I have removed the commentted line.
|
hey @dtantsur could we merge this and I'll fix the comments stuff in a new PR? Thanks |
|
@dtantsur Can we get this merged? thanks. |
|
Could you provide an update on the status of this PR and whether it's likely to be merged soon? |
|
@jobbler I wonder if https://github.com/kubevirt/redfish-controller would work for what you're trying to do? At least it's now part of KubeVirt directly, and should have access to the orgs CI tooling going forward. |
I also recommend everyone to migrate to KubeVirt's code. |
|
|
||
| # OCP scripts | ||
|
|
||
| These scripts are derivitives of the scripts in this repositories `kubevirt_scripts` directory and then modified to use populators to create the PVC for the CDROM ISO. |
There was a problem hiding this comment.
typo: derivatives
Most importantly, I don't even understand this sentence. What is derived from what?
|
|
||
| ## Building | ||
|
|
||
| The container image can be built by running `make build-ocp`. |
5 participants
Modified the kubevirt scripts to use volume populators